Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second set of changes to enable high DPI in Service Bus Explorer #800

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jmoralesv
Copy link
Contributor

This pull request continues the work started in pull-request: #797 by using TableLayoutPanels across several forms and user controls, to improve the rendering and resizing of the inner controls in a high DPI monitor, so there is no need for custom paint and resize logic in some cases.

  • Adding a TableLayoutPanel in the TimeSpanControl, to improve the scaling of the controls inside, so they can be displayed better. This also allows the control to have a bigger size in a container, and the controls can expand their size according to the container size.
  • Updating the HandleTopicControl to use the updated TimeSpanControl.
  • Changes for the layout, sizes and position of the controls in the HandleTopicControl, HandleSubscriptionControl and HandleRuleControl. The last one has some temporary changes, because the resize of the controls is messy without a TableLayoutPanel.
  • Adding a TableLayoutPanel to the HandleRuleControl, to improve the scaling and resizing of the child controls.
  • Changes for showing the grouperCorrelationFilter control in the HandleRuleControl.
  • Adding a TableLayoutPanel for the grouperCorrelationFilter control in the HandleRuleControl.
  • Aligning the layout of the rest of Handle controls (HandleConsumerGroup, HandleEventHub, HandleNotificationHub, HandleQueue, HandleRelay, HandleSubscription, HandleTopic), so the groupers and others are in similar positions.
  • Adding calls to SuspendDrawing, SuspendLayout, ResumeDrawing and ResumeLayout when rendering the groupers in the HandleRuleControl.
  • Changes for rendering the headers of the list views in the Handle controls, including HandlePartition, ListenerControl, PartitionListenerControl, TestEventHub, TestQueue, TestRelay, TestSubscription, and TestTopic, by calling e.DrawText.
  • Changes in the HandleNotificationHubControl, to use a table layout panel to improve the layout when rendering the form in a high DPI monitor. Because of this, the HandleNotificationHubControl_Resize method is no longer needed.
  • Removing the HandleRuleControl_Resize method in the HandleRuleControl.

…ing of the controls inside, so they can be displayed better. This also allows the control to have a bigger size in a container, and the controls can expand their size according to the container size. Updating the HandleTopicControl to use the updated TimeSpanControl.
…dleTopicControl, HandleSubscriptionControl and HandleRuleControl. The last one has some temporary changes, because the resize of the controls is messy without a TableLayoutPanel.
…aling and resizing of the child controls. There is code pending for the CorrelationFilter grouper.
…nel to improve the layout when rendering the form in a high DPI monitor.
@jmoralesv jmoralesv changed the title First set changes to enable high DPI in Service Bus Explorer Second set of changes to enable high DPI in Service Bus Explorer Aug 5, 2024
@ErikMogensen
Copy link
Collaborator

I want to wait with this PR until we have a solution for the blurriness for text in some scenarios as mentioned in #797.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants