Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-2143] Update readme for GA #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alexdicianu
Copy link
Contributor

No description provided.

@mbaynton
Copy link
Contributor

mbaynton commented Oct 19, 2020

Over in https://pantheon.slack.com/archives/CM9E09YDS/p1602869411003300 I was advocating for making one final change to these repos before removing the experimental label. In theory we should stop changing files outside of the upstream-configuration folder once we declare these repos ready.

@alexdicianu
Copy link
Contributor Author

@mbaynton looks like that card you referenced in slack got deprioritized. I ported some of the documentation updates from pantheon-systems/documentation#5663.

@alexdicianu alexdicianu requested a review from mbaynton November 4, 2020 12:23
@mbaynton
Copy link
Contributor

mbaynton commented Nov 5, 2020

I think we should keep the documentation pertinent to upstream maintainers in the separate file. Thinking about this being forked to an org's upstream with a bunch of downstream sites, the README for a given downstream site and the README for the upstream become unrelated documents. If we keep it as one file, downstream site maintainers might make edits and upstream maintainers might also make edits, causing merge conflicts just cause of docs.

@mbaynton
Copy link
Contributor

mbaynton commented Nov 5, 2020

I am wondering if the content duplication from docs is because of a comment I'd made that I didn't think all the documentation for these repos should be on the docs site because some of it would be more readily located by developers if it was right in the repo?

I think it would be fine to link to the docs page for the sections that have to do with actions taken on the dashboard / anything not about wrangling the files inside a fork of this repo.

Bottom line I thought the docs in this particular repo were pretty much good as they were, except for the stuff that says experimental. But it's docs, I'm not sure how much my opinion should matter on it at the end of the day either.

@alexdicianu
Copy link
Contributor Author

@mbaynton I'm unsure of what to put in the readme but, I admit that duplicating the docs is probably not a good idea (maintainability wise). Why not just have something simple like what we have now without the "experimental" part and just link to the docs page for which we have a process to edit and more people are empowered to do so?

Copy link
Contributor

@mbaynton mbaynton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been in my GitHub review requests for years and I don't seem to have another way to clear it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants