Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOPS-2047: Environment Variables to Terminus Functional Tests #2538

Merged
merged 3 commits into from
Feb 15, 2024
Merged

LOPS-2047: Environment Variables to Terminus Functional Tests #2538

merged 3 commits into from
Feb 15, 2024

Conversation

mitchellmarkoff
Copy link
Contributor

  • We still have some questions about the applications of env vars aside from TERMINUS_HOST but are ready for some review on our current implementation.

@stovak
Copy link
Member

stovak commented Feb 14, 2024

https://github.com/pantheon-systems/terminus/pull/2541/files

@stovak
Copy link
Member

stovak commented Feb 15, 2024

@mitchellmarkoff go ahead and merge mine in and then merge this one into the 3.x trunk.

@mitchellmarkoff mitchellmarkoff marked this pull request as ready for review February 15, 2024 14:13
@mitchellmarkoff mitchellmarkoff requested a review from a team as a code owner February 15, 2024 14:13
kporras07
kporras07 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the behavior when the variables are not set? Will it continue working as usual? If that's the case then 🚢 it

@mitchellmarkoff mitchellmarkoff merged commit 5a38020 into 3.x Feb 15, 2024
8 checks passed
@mitchellmarkoff mitchellmarkoff deleted the LOPS-2047 branch February 15, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kporras07 kporras07 kporras07 approved these changes

@stovak stovak stovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchellmarkoff @stovak @kporras07