[CMSP-1034] fix typo in tax_query #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
reviewed
Apr 23, 2024
|
Behat tests that are failing are on multidev deletion, the actual tests are passing. I've modified the |
pwtyler
approved these changes
Apr 24, 2024
| @@ -1,6 +1,7 @@ | |||
| ## Changelog ## | |||
|
|
|||
| ### 2.5.3-dev ### | |||
| ### 2.5.3 (April 24, 2024) ### | |||
There was a problem hiding this comment.
This should happen in release PR, not feature branch.
There was a problem hiding this comment.
I branched off main and then went back and changed things when I realized my mistake. See ee583cf
| @@ -235,7 +235,8 @@ Please report security bugs found in the source code of the Solr Power plugin th | |||
|
|
|||
| == Changelog == | |||
|
|
|||
| = 2.5.3-dev = | |||
| = 2.5.3 (April 24, 2024) = | |||
There was a problem hiding this comment.
as above this should be release pr but fine if you're shipping this manually.
jazzsequence
added a commit
that referenced
this pull request
Apr 24, 2024
* Prepare 2.5.3-dev * [JFDI] Plugin deploy uses checkout@v3 (#614) * [CMSP-721] Bump tested-up-to and output PHP Version (#617) * bump tested-up-to * output the PHP version so we can ensure we're testing on PHP 8.3 * Bump ip from 2.0.0 to 2.0.1 (#619) Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump yoast/phpunit-polyfills from 2.0.0 to 2.0.1 (#621) Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases) - [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md) - [Commits](Yoast/PHPUnit-Polyfills@2.0.0...2.0.1) --- updated-dependencies: - dependency-name: yoast/phpunit-polyfills dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [CMSP-1034] fix typo in tax_query (#622) * close parenthesis * add debugging code * add opening parenthesis Co-authored-by: Phil Tyler <[email protected]> * make the emoji sad * remove debug code * update changelog * bump version * if multidev:delete fails, don't fail the test --------- Co-authored-by: Phil Tyler <[email protected]> * drop -dev --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Phil Tyler <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds customer-supplied code for tax_queries from https://wordpress.org/support/topic/issue-building-query-when-you-are-parsing-the-tax_query/ props @offshorealert,