-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGS-5161] Update deprecated filter call #544
Conversation
6750fb8
to
e296885
Compare
On local, if SOLR_PATH is missing, you get a schema upload error when you maybe don't even really want to upload a schema. In that case, it would be helpful to know that the reason you can't activate the plugin is because the SOLR_PATH constant is missing.
Adds a die if you attempt to activate the plugin in a single site inside a multisite instance.
so just remove it
whitelist_options deprecated in WordPress 5.5
FILTER_SANITIZE_STRING is deprecated in PHP 8.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the mangling exception for jQuery makes me a bit nervous but I looked at the code and wasn't able to find a reason why it was originally added so I'd say LGTM
@kporras07 If it had had any adverse effects when I tried to run the build step, I would have tried to add it back in but nothing bad seemed to happen and everything still worked as expected so ¯_(ツ)_/¯ |
This PR resolves the issue reported in BUGS-5161 as well as making a number of other minor updates that improve the overall quality of the Solr Power plugin.
whitelist_options
filter name was deprecated in WP 5.5 in favor of the more inclusiveallowed_options
. The resolution is simply using the new filter name.sanity_check
withenvironment_check
for similar reasons e296885SOLR_PATH
is not defined, on activation, the plugin assumes you want to upload a schema. This is likely not the case, but the error message does not tell you what's wrong. This PR updates the error message to indicate thatSOLR_PATH
is not defined, so if that's the problem, you might know how to fix it. 8a5cbc9wp_die
if you activate on a single site of a multisite and links to the Network Admin Plugins page to network activate there.grunt-sass
. This PR updates thepackage.json
to requirenode-sass
and implements this in the Gruntfile.[]
) or warn about not aligning equals signs.fixes #541
related #538