Read host and port information from solr instance, not Pantheon env variables #411
Conversation
… on get_solr not being called inside get_server_info?
|
@danielbachhuber I'm having some issues with my tests - they don't see |
tests/phpunit/test-solrpower-api.php
Outdated
|
|
||
|
|
||
| function test_server_info_uses_actual_config() { | ||
| $env_host = array_key_exists('PANTHEON_INDEX_HOST', $_ENV) ? $_ENV['PANTHEON_INDEX_HOST'] : ''; |
There was a problem hiding this comment.
I'm having some issues with my tests - they don't see PANTHEON_INDEX_HOST set in the env. (You can see my past few commits trying to fiddle around with this.) Shouldn't bootstrap.php be taking care of that?
@pavellishin try using getenv instead of the $_ENV global
There was a problem hiding this comment.
Oh, duh, I thought the previous code accessed it directly :P
| $override_host = $env_host . 'OVERRIDE'; | ||
| $override_port = $env_host . 'OVERRIDE'; | ||
|
|
||
| $override_connection = function() { |
There was a problem hiding this comment.
@pavellishin I don't think $override_host is defined in the context of this function. Maybe pass it in as a parameter?
There was a problem hiding this comment.
oh, dangit. I forget how modern PHP works wrt scoping.
|
Sorry I abandoned this for a few weeks, busy times at work and home :/ |
|
Argh, I gotta set up phpunit and a test wordpress DB locally. |
See issue #408