Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PCC-1778] remove turbo json file from starter kit upon init #325

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[PCC-1778] remove turbo json file from starter kit upon init #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b3ee7b
No longer download turbo.json when using init command. Remove deprect…
kevinstubbs Dec 8, 2024
9080583
Add missing changeset.
kevinstubbs Dec 8, 2024
8c47810
Merge branch 'main' into PCC-1778-remove-turbo-json-file-from-starter…
kevinstubbs Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/ten-cats-swim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@pantheon-systems/pcc-cli": minor
---

No longer download turbo.json when initializing a new project from the starter
kit.
1 change: 0 additions & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"license": "MIT",
"keywords": [
"pcc",
"gatsby",
"nextjs",
"react",
"pantheon"
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/cli/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ yargs(hideBin(process.argv))
.option("template", {
describe: "Template from which files should be copied.",
type: "string",
choices: ["nextjs", "gatsby", "vue"],
choices: ["nextjs"],
default: "nextjs",
demandOption: true,
})
Expand Down
5 changes: 4 additions & 1 deletion packages/cli/src/lib/downloadTemplateDirectory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ export async function downloadTemplateDirectory(
printVerbose?: boolean,
) {
try {
const files = await fetchFiles(directory, printVerbose);
// Fetch files but ignore certain ones.
const files = (await fetchFiles(directory, printVerbose)).filter(
(file) => !["turbo.json"].includes(file.path),
);

await Promise.all(files.map((file) => output(file, outputDirectory)));

Expand Down
Loading