[PCC-1128] Improve OpenGraph information generation #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinstubbs
approved these changes
Oct 16, 2024
| article.metadata?.["Hero Image"], | ||
| // Extend as needed | ||
| ] | ||
| .filter((url): url is string => typeof url === "string") | ||
| .map((url) => ({ url })); | ||
| const description = article.metadata?.description | ||
| ? String(article.metadata?.description) |
There was a problem hiding this comment.
I don't have enough context yet to review the PR. But on a casual glance, I noticed this.
optional chaining again in String(article.metadata?.description) might not necessary. I see this in other places too
There was a problem hiding this comment.
Ah yeah that's true, I'll pay more attention to these. It'd be good to catch these in linting too, I'll see if I can get a PR out adding an ESLint rule for this.
There was a problem hiding this comment.
that would be nice .. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates SEO information generators to build better OG data based on standard metadata values
Screenshots