New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Universal Router #9

Closed

anon-xxs wants to merge 2 commits into main from universal-router

anon-xxs commented Apr 9, 2024

No description provided.


          feat: Universal Router

9aa8005

anon-xxs requested review from 0xjojoex, ChefMist and chefburger

April 9, 2024 05:40


          format prettier

7ab43b3

Collaborator

ChefMist commented Apr 9, 2024 •

edited

Loading

Initial thoughts is that universal router should be on its own repository eg. pancakeswap/universal-router

Reason

universal router is not just v4, it includes v2/v3/v4 and nft
our previous universal router is not inside v3-periphery as well
if dev import v4-periphery, do we want to automatically include universal router?

what do you think?

if this make sense also would encourage split this into multiple PR in the new repository

PR 0 (optional): repository setup etc..
PR 1: the current universal router implementation -- (these are code that are already in prod)
PR 2: changes to add v4 in universal router -- where devs will focus their review on this PR

ChefSnoopy closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet