Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Extract quoter common part #49

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Feat/Extract quoter common part #49

merged 4 commits into from
Jul 2, 2024

Conversation

ChefSnoopy
Copy link
Collaborator

Extract quoter common part

@ChefSnoopy ChefSnoopy requested review from ChefMist and chefburger July 1, 2024 06:41
chefburger
chefburger previously approved these changes Jul 1, 2024
Copy link
Collaborator

@chefburger chefburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The code looks way neater 🚀

error NotSelf();
error UnexpectedRevertBytes(bytes revertData);

struct PathKey {
Copy link
Collaborator

@chefburger chefburger Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry i forgot this one. Can u check src/interfaces/ISwapRouterBase ? There is also a PathKey definition. Do u think it's better to pull out the definition and move to it src/libraries/PathKey.sol ? So that we can close pancakeswap/pancake-v4-periphery#41 as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. let me check this

ChefMist
ChefMist previously approved these changes Jul 1, 2024
@ChefSnoopy ChefSnoopy dismissed stale reviews from ChefMist and chefburger via 7cb8386 July 2, 2024 03:12
Copy link
Collaborator

@chefburger chefburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChefSnoopy ChefSnoopy merged commit 940e6ed into main Jul 2, 2024
2 checks passed
@ChefSnoopy ChefSnoopy deleted the feat/quoter-refactor branch July 2, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants