-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Extract quoter common part #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. The code looks way neater 🚀
src/interfaces/IQuoter.sol
Outdated
error NotSelf(); | ||
error UnexpectedRevertBytes(bytes revertData); | ||
|
||
struct PathKey { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry i forgot this one. Can u check src/interfaces/ISwapRouterBase
? There is also a PathKey definition. Do u think it's better to pull out the definition and move to it src/libraries/PathKey.sol
? So that we can close pancakeswap/pancake-v4-periphery#41 as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. let me check this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Extract quoter common part