Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 2] fix: add extra check for key.parameters unused bits #60

Conversation

ChefMist
Copy link
Collaborator

This PR is on top of #56

  1. fix those dynamic fee update which changes gas (will change to snapLastCall -- seems like we need to update our dependencies) -- so add a //todo now

  2. optimise the initialize. remove the +1

Copy link
Collaborator

@chefburger chefburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChefMist ChefMist merged commit 79e15e2 into fix/extra-check-for-keyParameters-unused-bits May 31, 2024
2 checks passed
@ChefMist ChefMist deleted the fix/extra-check-for-keyParameters-unused-bits-v2 branch May 31, 2024 02:47
ChefMist added a commit that referenced this pull request May 31, 2024
* fix: add extra check for key.parameters unused bits

* feat: gas optimization and fix dynamic fee fuzz (#60)

---------

Co-authored-by: ChefMist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants