[Part 2 of 2] feat: minor tweaks (add unchecked) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
changed the title
ChefMist
changed the title
ChefMist
changed the title
|
Need to format the codes |
ChefSnoopy
reviewed
May 8, 2024
| SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128()); | ||
| unchecked { | ||
| SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128()); | ||
| currency.transfer(to, amount); |
There was a problem hiding this comment.
Not sure whether there are any security issues .
Now we update the reservesOfVault after transfer token.
But after we merge the PR 33(reserveOf transient) , should be fine.
chefburger
reviewed
May 8, 2024
ChefSnoopy
previously approved these changes
May 9, 2024
chefburger
reviewed
Jun 5, 2024
| unchecked { | ||
| SettlementGuard.accountDelta(msg.sender, currency, -(amount.toInt128())); | ||
| _mint(to, currency, amount); | ||
| } |
There was a problem hiding this comment.
- amount is positive
- if
amount.toInt128doesn't revert, then amount is a valid int128 - combine 1 & 2, converting from positive to negative will never go overflow
chefburger
reviewed
Jun 5, 2024
| SettlementGuard.accountDelta(msg.sender, currency, -(amount.toInt128())); | ||
| currency.transfer(to, amount); | ||
| unchecked { | ||
| SettlementGuard.accountDelta(msg.sender, currency, -(amount.toInt128())); |
chefburger
reviewed
Jun 5, 2024
| if (amount == 0) amount = (-SettlementGuard.getCurrencyDelta(target, currency)).toUint256(); | ||
| SettlementGuard.accountDelta(msg.sender, currency, -(amount.toInt128())); | ||
| SettlementGuard.accountDelta(target, currency, amount.toInt128()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
- amount is positive
SettlementGuard.getCurrencyDelta(target, currency)cant be over int128 otherwise it will revert in line 144
ChefMist
commented
Jun 5, 2024
There was a problem hiding this comment.
looks good, @chefburger since this PR was originally raised on my end, can you approve so we can merge? thx
chefburger
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncheckedto reduce gas