feat: burn 1e3 shares for first mint into BinPool #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChefMist
changed the title
ChefMist
changed the title
This was referenced Nov 13, 2024
chefburger
reviewed
Nov 13, 2024
ChefMist
commented
Nov 13, 2024
| 137102 |
There was a problem hiding this comment.
can see it cost 30k more gas when there's 3 empty bins (eg. add-remove liquidity from bin however bin id still in TreeMath due to minShare)
There was a problem hiding this comment.
Yeah, and once a bin get "polluted", it will never get back 😂
What if we add a "symmetric operation" i.e. the last ppl removing liquidity receives MINIUM_SHARE ?
* feat: example if we tweak add/remove bin to tree * feat: updated gas cost * feat: add test around getNextNonEmptyBin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a first mint happen for BinPool, we'll burn 1e3 liquidity. The goal of this is to prevent share inflation attack.
Potentially
Can also #215 -- i would suggest we also merge that as
swapslikely happen more often thatmint/burnand the PR would optimise swap gas cost greatly