Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getFeeGrowthInside view function for off-chain farming #17

Closed
wants to merge 2 commits into from
Closed

Add getFeeGrowthInside view function for off-chain farming #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a33d3
feat: Add events and methods for off-chain farming
chef-omelette Apr 16, 2024
fc9bed2
feat: Remove SwapFees event
chef-omelette Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_againstLiquidity.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
54822
54779
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_leaveSurplusTokenInVault.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
102898
102855
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_runOutOfLiquidity.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
25042646
25042603
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_simple.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
36022
35979
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_useSurplusTokenAsInput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
101660
101617
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_withHooks.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
41672
41629
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#swap_withNative.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
36025
35982
2 changes: 1 addition & 1 deletion .forge-snapshots/CLPoolManagerTest#testNoOp_gas_Swap.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
21667
21624
2 changes: 1 addition & 1 deletion .forge-snapshots/ExtsloadTest#extsloadInBatch.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
11352
11397
8 changes: 8 additions & 0 deletions src/pool-cl/CLPoolManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,14 @@ contract CLPoolManager is ICLPoolManager, Fees, Extsload {
return pools[id].tickBitmap[word];
}

function getPoolFeeGrowthInside(PoolId id, int24 tickLower, int24 tickUpper)
external
view
returns (uint256 feeGrowthInside0X128, uint256 feeGrowthInside1X128)
{
return pools[id].getFeeGrowthInside(tickLower, tickUpper);
}

/// @inheritdoc ICLPoolManager
function setMasterChef(address _masterChef) external override onlyOwner {
masterChef = _masterChef;
Expand Down
10 changes: 10 additions & 0 deletions src/pool-cl/libraries/CLPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,4 +490,14 @@ library CLPool {
function isNotInitialized(State storage self) internal view returns (bool) {
return self.slot0.sqrtPriceX96 == 0;
}

function getFeeGrowthInside(State storage self, int24 tickLower, int24 tickUpper)
internal
view
returns (uint256 feeGrowthInside0X128, uint256 feeGrowthInside1X128)
{
return self.ticks.getFeeGrowthInside(
tickLower, tickUpper, self.slot0.tick, self.feeGrowthGlobal0X128, self.feeGrowthGlobal1X128
);
}
}