Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing on Windows #2803

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Improve typing on Windows #2803

merged 4 commits into from
Dec 22, 2024

Conversation

AndreasBackx
Copy link
Collaborator

@AndreasBackx AndreasBackx commented Nov 9, 2024

I was working from Windows for a change, so why not fix some of the typing here?

This makes it so running the type checks on all platforms no longer gives any errors. Additionally, tox.ini has been updated to make sure it runs all tests on all platforms. This will do some extra work and make things slower unfortunately. I think if we move to uv in the future, we can make this faster (from having a short glance at some information I saw online). One can also run tox in parallel, though for some reason you cannot seem to enable that from the config.

  • Add tests that demonstrate the correct behavior of the change. Tests
    should fail without the change.
    • No behaviour has been altered.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.

@AndreasBackx AndreasBackx marked this pull request as ready for review November 9, 2024 16:53
@AndreasBackx AndreasBackx added windows Issues pertaining to the Windows environment typing labels Nov 9, 2024
@AndreasBackx AndreasBackx merged commit 45f89cd into main Dec 22, 2024
12 checks passed
@AndreasBackx AndreasBackx deleted the typing/windows branch December 22, 2024 20:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typing windows Issues pertaining to the Windows environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant