Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests requirements to fix python 3.12 testing #2541

Closed
wants to merge 1 commit into from

Conversation

darless
Copy link
Contributor

@darless darless commented Jun 27, 2023

Python 3.12 was failing to run the py312 environment. The pytest version was 7.3.1. Updating to 7.4.0 fixed the issue.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@darless
Copy link
Contributor Author

darless commented Jun 27, 2023

@davidism Does this work as a fix for you? I ran pip-compile on requirements/tests.in which updated pytest from 7.3.1 to 7.4.0 and fixed the test issue.

@davidism
Copy link
Member

Addressed in b5280c6

@davidism davidism closed this Jun 27, 2023
@darless darless deleted the python-3.12-fix branch June 27, 2023 17:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click tests fails on Python 3.12.0-beta.1
2 participants