(feat) Billable Exemption config #503
Conversation
|
Please share a screenshot of the new look. |
|
The shared Preview screen is the new screen. I tried to maintain the same look as the previous one. The edit schema screen did not change. |
This is appropriate to the directory and files' presentation. You can use the default tree view look from carbon. Sorry for taking you round
|
|
Do you mean without the icons? |
donaldkibet
force-pushed
the
exemption-config
branch
from
0bfece5 to
f3d0f48
Compare
| <div> | ||
| {errors.length && validationOn ? <ErrorMessages /> : null} | ||
| <AceEditor | ||
| style={{ height: '100vh', width: '100%', border: errors.length ? '3px solid #DA1E28' : 'none' }} |
There was a problem hiding this comment.
We should extract these syles to scss file
| gap: 0.5rem; | ||
|
|
||
| :global(.cds--actionable-notification) { | ||
| max-width: 38rem; |
There was a problem hiding this comment.
Will this be responsive on a small screen
| .pagination { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 0.5rem; |
There was a problem hiding this comment.
Lets use the carbon tokens for size
| icon: React.ReactNode; | ||
| } | ||
|
|
||
| const transformDataToTree = (data: Record<string, any>, parentKey = 'root'): TreeNode[] => { |
There was a problem hiding this comment.
| const transformDataToTree = (data: Record<string, any>, parentKey = 'root'): TreeNode[] => { | |
| const transformDataToTree = (data: Record<string, any>, parentKey = 'root'): Array<TreeNode> => { |
| import useSWRImmutable from 'swr/immutable'; | ||
| import { openmrsFetch } from '@openmrs/esm-framework'; | ||
|
|
||
| export function useStandardSchema(key: string) { |
There was a problem hiding this comment.
should we rename this to useExemptionSchema
| headers, | ||
| body, | ||
| }); | ||
| } |
There was a problem hiding this comment.
should we combine the functionality in useStandardSchema.tsx and this file to one hook. They all access and manipulate the same endpoint
| @@ -46,6 +47,7 @@ const RootComponent: React.FC = () => { | |||
| <Route path="/bill-manager" element={<BillManager />} /> | |||
| <Route path="/charge-items" element={<ChargeItemsDashboard />} /> | |||
| <Route path="/payment-modes" element={<PaymentModeHome />} /> | |||
| <Route path="/billable-exemptions" element={<BillableExemptions />} /> | |||
There was a problem hiding this comment.
After this PR is merged. Add a ticket to add control access by adding correct config for it
|
|
||
| export interface Schema { | ||
| services: { | ||
| all: Service[]; |
There was a problem hiding this comment.
| all: Service[]; | |
| all: Array<Service> |
its a nit but that the convention we are using on the project
|
@Ogollah merging this in to test it out. you can follow up with PR to fix the recommended changes |
Requirements
Summary
What does this PR do?
Screenshots
*Schema editor
None.
Related Issue
None.
Other
None.