-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ccc and patient name to manifest samples table and flu sample types #498
Add ccc and patient name to manifest samples table and flu sample types #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Omoshlawi
key: 'patient', | ||
}, | ||
{ | ||
header: t('cccKDODNumber', 'CCC/KDOD Number'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the KDOD number same as ccc number? I can't remember cc @njorocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats how it was named in 2.x, unless they are different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saw that we have kdod identifier type, should it check for ccc, if not found then look for kdod identifier for the patient?and if all are available which one should be displayed? cc @PatrickWaweru @donaldkibet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the system type. If it is a KDOD system, display KDOD. Else, display CCC.
@@ -28,8 +28,14 @@ export const configSchema = { | |||
{ sampleType: 'DBS', labManifestType: ['1'] }, | |||
], | |||
}, | |||
cccNumberIdentifierType: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just have the ccc identifier type or should it be an array of identifiers to be used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the manifest samples, the required identifier of interest was only ccc for verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just found out we have kdod identifier type as well, so based on teams recommendation on bellow quoted question, i might change it as you have recommended
just saw that we have kdod identifier type, should it check for ccc, if not found then look for kdod identifier for the patient?and if all are available which one should be displayed? cc @PatrickWaweru @donaldkibet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the system type. If it is a KDOD system, display KDOD. Else, display CCC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PatrickWaweru, @Omoshlawi we will have to check the global property to determine which identifier to show.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, FIXED cc @donaldkibet
…e kdod sites.Added sample types for FLU manifest type
Requirements
Summary
Screenshots
manifest.mp4
None.
Related Issue
None.
Other
None.