Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccc and patient name to manifest samples table and flu sample types #498

Conversation

Omoshlawi
Copy link
Collaborator

@Omoshlawi Omoshlawi commented Dec 3, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

  • Added patient name and ccc to to manifest sample for easy verification
  • Added flu sample types

Screenshots

Screenshot 2024-12-03 at 08 53 29
manifest.mp4

None.

Related Issue

None.

Other

None.

@Omoshlawi Omoshlawi requested a review from donaldkibet December 3, 2024 05:57
makombe
makombe previously approved these changes Dec 3, 2024
Copy link
Collaborator

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Omoshlawi

key: 'patient',
},
{
header: t('cccKDODNumber', 'CCC/KDOD Number'),
Copy link
Collaborator

@makombe makombe Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the KDOD number same as ccc number? I can't remember cc @njorocs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats how it was named in 2.x, unless they are different

Copy link
Collaborator Author

@Omoshlawi Omoshlawi Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw that we have kdod identifier type, should it check for ccc, if not found then look for kdod identifier for the patient?and if all are available which one should be displayed? cc @PatrickWaweru @donaldkibet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the system type. If it is a KDOD system, display KDOD. Else, display CCC.

@@ -28,8 +28,14 @@ export const configSchema = {
{ sampleType: 'DBS', labManifestType: ['1'] },
],
},
cccNumberIdentifierType: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just have the ccc identifier type or should it be an array of identifiers to be used here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the manifest samples, the required identifier of interest was only ccc for verification

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found out we have kdod identifier type as well, so based on teams recommendation on bellow quoted question, i might change it as you have recommended

just saw that we have kdod identifier type, should it check for ccc, if not found then look for kdod identifier for the patient?and if all are available which one should be displayed? cc @PatrickWaweru @donaldkibet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the system type. If it is a KDOD system, display KDOD. Else, display CCC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickWaweru, @Omoshlawi we will have to check the global property to determine which identifier to show.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, FIXED cc @donaldkibet

…e kdod sites.Added sample types for FLU manifest type
@Omoshlawi Omoshlawi changed the title Add ccc and patient name to manifest samples table Add ccc and patient name to manifest samples table and flu sample types Dec 3, 2024
@donaldkibet donaldkibet enabled auto-merge (squash) December 3, 2024 15:02
@donaldkibet donaldkibet merged commit 969cf9a into palladiumkenya:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants