Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) KHP3-7113 : Deactivating a Billable item not working #494

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

donaldkibet
Copy link
Contributor

@donaldkibet donaldkibet commented Nov 28, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

This PR is linked to this (ticket)[https://thepalladiumgroup.atlassian.net/browse/KHP3-7113]. The issue had already been fixed. cc @ojwanganto @makombe @patryllus we might want to validate concepts while doing bulk update, this is to ensure that chargeable items are always associated with a charge item.

In this update, I have added a warning when we have incomplete data, so users are able to point out why enabling and disabling a service or stock item isn't working.

Screenshots

Kapture.2024-11-28.at.16.06.12.webm

Related Issue

None.

Other

None.

@ojwanganto
Copy link
Contributor

Thanks, @donaldkibet. Did you mean linking a charge item to a commodity or an orderable?

@donaldkibet
Copy link
Contributor Author

Thanks, @donaldkibet. Did you mean linking a charge item to a commodity or an orderable?

Yes, i believe part of the reason why they are unable to change status is because, users create a stock item that is not associated with a drug or stock item. This leads to the errors mentioned in the PR

@ojwanganto
Copy link
Contributor

Thanks, @donaldkibet. Did you mean linking a charge item to a commodity or an orderable?

Yes, i believe part of the reason why they are unable to change status is because, users create a stock item that is not associated with a drug or stock item. This leads to the errors mentioned in the PR

Makes sense. Thanks for the fix. Am wondering why those details can be null

Copy link
Collaborator

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donaldkibet

@makombe makombe merged commit 099a416 into main Nov 29, 2024
@makombe makombe deleted the KHP3-7113 branch November 29, 2024 07:17
Ogollah pushed a commit that referenced this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants