fix: settle bills on correct cash point #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojwanganto
reviewed
Nov 14, 2024
| @@ -51,7 +52,7 @@ export const createPaymentPayload = ( | |||
| updatedLineItems.filter((item) => item.paymentStatus === 'PENDING').length === 0 ? 'PAID' : 'PENDING'; | |||
|
|
|||
| const processedPayment = { | |||
| cashPoint: bill.cashPointUuid, | |||
| cashPoint: timesheet.cashPoint.uuid, | |||
There was a problem hiding this comment.
is it safe to just check for NULLs?
|
@makombe @Omoshlawi @donaldkibet - please help with reviews |
donaldkibet
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks @amosmachora LGTM if we could address @ojwanganto feedback its good to go
donaldkibet
force-pushed
the
fix/settle-on-correct-cashpoint
branch
from
2d5503c
to
eb4d339
Compare
donaldkibet
force-pushed
the
fix/settle-on-correct-cashpoint
branch
from
eb4d339
to
bcad399
Compare
|
@donaldkibet there was a conflict on this branch I do not know if you addressed it before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds a way to settle a bill at the correct cash point. Previously it was assumed that where you create the bill is where it's settled.
Screenshots
An example of settling a bill at a 'non-default' payment point.
None.
Related Issue
None.
Other
None.