Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat KHP3-7051: Implement styling for unsettled bill #450

Merged
merged 22 commits into from
Dec 9, 2024

Conversation

its-kios09
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Screenshots

improvements

Related Issue

see https://thepalladiumgroup.atlassian.net/browse/KHP3-7051
None.

Other

None.

@donaldkibet
Copy link
Contributor

Thanks @its-kios09 how does this look for imaging and procedure orders

@its-kios09
Copy link
Collaborator Author

@donaldkibet I can updated the UI to attain the uniformity

@ojwanganto
Copy link
Contributor

Do we still need this? @makombe @its-kios09

@its-kios09
Copy link
Collaborator Author

@donaldkibet I think I will revert the scss styling to maintain the uniformity across the procedure, lab and radiology

@its-kios09
Copy link
Collaborator Author

its-kios09 commented Nov 29, 2024

Thanks @donaldkibet, I hope the changes haven’t disrupted the layout of the other ESMS. This is what we have collaborated on with the UI/UX design squad from the community.
Peek 2024-11-29 11-50

@ojwanganto
Copy link
Contributor

@donaldkibet @makombe - please help with reviews. @its-kios09 - fix the conflicts

@its-kios09
Copy link
Collaborator Author

@ojwanganto sorted

Copy link
Contributor

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@its-kios09 how does the button look like on dispensing app before we merge this in

@its-kios09
Copy link
Collaborator Author

@donaldkibet It looks the same. The only change I made is aligning the text to the center of the button.

@its-kios09 its-kios09 merged commit 5387290 into palladiumkenya:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants