Regimem component #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Thank you, @makombe! 🚀 I've added a few suggestions for consideration.
packages/esm-care-panel-app/src/care-panel/care-panel.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-care-panel-app/src/regimen-editor/regimen-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-care-panel-app/src/regimen-editor/regimen-form.component.tsx
Outdated
Show resolved
Hide resolved
donaldkibet
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Thanks @makombe 🍻
Just need to remove useOverlay hook file since we won't need it.
Feel free to merge once that is done
|
@donaldkibet Thanks for the catch, I forgot to remove it when refactoring. Fixed |
added 2 commits
September 28, 2023 09:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
None.
Related Issue
None.
Other