-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update billable services workspace #267
Update billable services workspace #267
Conversation
@agesa3 could you please attach a video showing what this PR does? Thanks |
I've attached a video but still there is an issue with the backend API when it comes to updating I had informed @Injiri about it and he was to action on it since the API creates a new entry rather than updating.If that is sorted out the code will be fully ready since on the frontend everything seems to be ok. |
@agesa3 - You may have forgotten to upload the video. Also, kindly resolve the conficts |
Actioning on it |
Thanks, @agesa3. Could you please look at the styling for the edit form? The margins don't look OK. |
Done.Updated the styling and video
Done and updated the video. @donaldkibet any guidance on this .In my local the import works ok but here on CI it seems the import of WorkspaceContainer is not found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agesa3
@@ -37,6 +46,12 @@ const BillableServices = () => { | |||
const [showOverlay, setShowOverlay] = useState(false); | |||
const [overlayHeader, setOverlayTitle] = useState(''); | |||
|
|||
const handleEditClick = (initialData) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a type for the initialData
and probably update the name to something close e.g service
We should update to the latest version of |
@agesa3 - thanks for the updates. You will at least need to refine styling of the form. Kindly ping the team once you have something to be reviewed. |
@ojwanganto sorry had uploaded the wrong video.Ive corrected and uploaded the correct one |
@agesa3 are you available to complete on this task? We need it urgently |
I completed it as at last week not unless there is any update that I need to make.Ive noticed there is some conflict and am resolving it now. |
@agesa3 - so is the problem an issue with the backend? |
Yes, Simon had created a fix and it was merged and it worked ok but then a few days after that it started failing and whenever an update is made it creates a new entry rather than updating. |
fbc80b9
to
527ea91
Compare
This reverts commit 5b81cb1.
Requirements
Summary
Screenshots
Screen.Recording.2024-07-25.at.16.24.51.mov
None.
Related Issue
None.
Other
None.