Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/track subtr #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tagirahmad
Copy link
Contributor

@tagirahmad tagirahmad commented Sep 11, 2023

What is the purpose of this pull request?

Solves issue by implementing SQL subtransactions detecting and reacting on it depending on specified configuration.

What changes did you make? (overview)

You can use feature like:

Isolator.configure do |config|
  # When to report nested substransactions depending on the depth (32 is the default)
  config.substransactions_depth_threshold = 32
   # Specify a custom logger to log offenses
  config.report_subtransactions = :log # or :exception or :notifier for uniform_notifier
end

Is there anything you'd like reviewers to focus on?

Checklist

  • I've added tests for this change
  • I've added a Changelog entry
  • I've updated a documentation

Copy link
Owner

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We introduced some new APIs and concepts since you've opened the PR, so I would like to upgrade the implementation as follows:

  • The functionality MUST be implemented as a plugin (see example).
  • No need to add custom reporting, just a single configuration parameter to specify the limit (and activate the feature).

@palkan palkan force-pushed the master branch 2 times, most recently from e2f0bd7 to 5ddefff Compare April 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants