add Accessor<boolean> as an attribute type (#3482)

palantir · Feb 4, 2019 · e9fb12f · e9fb12f · blueprint-bot · Feb 4, 2019
1 parent b6e36fb
commit e9fb12f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/plots/plot.ts b/src/plots/plot.ts
@@ -333,10 +333,10 @@ export class Plot extends Component {
    * Sets a particular attribute to a constant value or the result of an Accessor.
    *
    * @param {string} attr
-   * @param {number|string|Accessor<number>|Accessor<string>} attrValue
+   * @param {number|string|Accessor<number>|Accessor<string>|Accessor<boolean>} attrValue
    * @returns {Plot} The calling Plot.
    */
-  public attr(attr: string, attrValue: number | string | IAccessor<number> | IAccessor<string>): this;
+  public attr(attr: string, attrValue: number | string | IAccessor<number> | IAccessor<string> | IAccessor<boolean>): this;
   /**
    * Sets a particular attribute to a scaled constant value or scaled result of an Accessor.
    * The provided Scale will account for the attribute values when autoDomain()-ing.

diff --git a/src/plots/xyPlot.ts b/src/plots/xyPlot.ts
@@ -360,9 +360,13 @@ export class XYPlot<X, Y> extends Plot {
   protected _getDataToDraw(): Utils.Map<Dataset, any[]> {
     const dataToDraw: Utils.Map<Dataset, any[]> = super._getDataToDraw();
 
+    const definedAttr = this.attr("defined");
     const definedFunction = (d: any, i: number, dataset: Dataset) => {
       const positionX = Plot._scaledAccessor(this.x())(d, i, dataset);
       const positionY = Plot._scaledAccessor(this.y())(d, i, dataset);
+      if (definedAttr && definedAttr.accessor(d, i, dataset) === false) {
+        return false;
+      }
       return Utils.Math.isValidNumber(positionX) &&
         Utils.Math.isValidNumber(positionY);
     };