Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version filter to accept the new 2.x version line #193

Closed
wants to merge 1 commit into from

Conversation

ForestEckhardt
Copy link
Contributor

This version line help to resolve an issue that I was having with watchexec running on the Static Stack.

watchexec/watchexec#814

@ForestEckhardt ForestEckhardt requested a review from a team as a code owner April 22, 2024 19:09
@dmikusa
Copy link
Contributor

dmikusa commented Apr 22, 2024

My usual question with major version bumps is do we need to keep supporting the previous major version. I don't know what's changed between the version we're bundling and the latest major, but it's been a while since we updated. We should probably do some quick tests with the use cases we support and the new major version to see if anything breaks.

It's easier to just migrate major versions and for tools like this, we're not usually installing them for the user but for features in the buildpacks so I feel like we can justify changing the version and dropping the old version at the same time so long as we're all on the same page and we don't break any of our buildpacks. Thoughts on that?

@ForestEckhardt
Copy link
Contributor Author

From what I could gather from the release notes this is mostly to get over the first breaking change hump as well as cleaning up a long list of things that have been deprecated for a while. I don't see anything that has been deprecated that we are currently leveraging. I personally don't think that there will be any issue with releasing this new version but it is something that we may need to keep a closer eye on as it sounds like the rate of major releases may be increasing.

@dmikusa
Copy link
Contributor

dmikusa commented Apr 24, 2024

Ok, it sounds like we should probably jump to 2.x and if someone needs to hang back on 1.x, they can do that by pinning the version of the Watchexec buildpack. It'll be a major version jump for the buildpack, so that should help people recognize there's a change.

To update, we need to:

  1. Update buildpack toml with the new metadata: https://github.com/paketo-buildpacks/watchexec/blob/main/buildpack.toml#L35-L64
  2. Update .github/pipeline-descriptor.yml with the new version tag filter. https://github.com/paketo-buildpacks/watchexec/blob/main/.github/pipeline-descriptor.yml#L22-L43

You don't need to worry about the individual workflow files. The Update Pipeline job will regenerate those based on the info in 1.) and 2.).

@ForestEckhardt
Copy link
Contributor Author

  1. Update buildpack toml with the new metadata: https://github.com/paketo-buildpacks/watchexec/blob/main/buildpack.toml#L35-L64

I was hoping to have this done automatically by the automation. Would it be acceptable to just make the change to the pipeline descriptor?

@dmikusa
Copy link
Contributor

dmikusa commented Apr 25, 2024

I don't think so, but I've not tried it. I think you're going to minimally need to update the versions & URLs. The sha hashes don't need to be correct, but they need to be something. I'll sometimes put the literal string bad for the hashes. The update workflow will submit a PR to correct those later. Things do go more smoothly with the hashes though, as the PR tests will fail if they are incorrect.

@ForestEckhardt
Copy link
Contributor Author

Closing in favor of this PR #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants