Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builders from bionic -> jammy #625

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Update builders from bionic -> jammy #625

merged 2 commits into from
Sep 27, 2023

Conversation

arjun024
Copy link
Member

@arjun024 arjun024 commented Sep 25, 2023 •
edited
Loading

Remove all bionic builder uses.
Replace with jammy builder wherever jammy builders weren't used.

Also for httpd tests: modify test app to work on jammy stack

Fixes #624

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@arjun024
Update builders from bionic -> jammy
944050d 
Remove all bionic builder uses.
Replace with jammy builder wherever jammy builders weren't used.

Fixes github.com//issues/624
@arjun024 arjun024 marked this pull request as ready for review September 25, 2023 22:16
@arjun024 arjun024 requested review from a team as code owners September 25, 2023 22:16
robdimsdale
robdimsdale previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@robdimsdale robdimsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this 👍

@arjun024
httpd tests: modify test app to work on jammy stack
c938ae8 
Paketo jammy stack has restrictions on runtime user
writing to app workspace. Therefore, don't use a pid-file
in the app working dir.
@anthonydahanne anthonydahanne self-requested a review September 26, 2023 21:32
@arjun024 arjun024 enabled auto-merge (squash) September 27, 2023 01:31
@anthonydahanne anthonydahanne mentioned this pull request Sep 27, 2023
Merged
5 tasks
@arjun024 arjun024 merged commit 8a3cb7a into main Sep 27, 2023
4 checks passed
@arjun024 arjun024 deleted the update-builder branch September 27, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

@anthonydahanne anthonydahanne anthonydahanne approved these changes

@robdimsdale robdimsdale robdimsdale left review comments

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/content-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change builders coordinates for non Java buildpacks
4 participants
@arjun024 @anthonydahanne @robdimsdale @ForestEckhardt