Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates buildpacks in buildpack.toml #680

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

paketo-bot
Copy link
Member

No description provided.

@paketo-bot paketo-bot requested a review from a team as a code owner September 28, 2023 18:32
@paketo-bot paketo-bot enabled auto-merge (rebase) September 28, 2023 18:41
@thitch97 thitch97 added the semver:minor A change requiring a minor version bump label Nov 2, 2023
@francoissharpe
Copy link

Could this PR be merged? I would eagerly like to have the poetry buildpack update, thanks!

@TheSuperiorStanislav
Copy link

Could this PR be merged? I would eagerly like to have the poetry buildpack update, thanks!

Pretty please

@robdimsdale
Copy link
Member

Sorry, we've been having issues with the CI. I'm going to close and re-open this to re-trigger it.

auto-merge was automatically disabled November 17, 2023 17:54

Pull request was closed

@robdimsdale robdimsdale reopened this Nov 17, 2023
@robdimsdale robdimsdale force-pushed the automation/buildpack.toml/update branch from 885b385 to c399708 Compare November 17, 2023 17:54
@robdimsdale robdimsdale enabled auto-merge (rebase) November 17, 2023 17:54
robdimsdale
robdimsdale previously approved these changes Nov 17, 2023
@robdimsdale
Copy link
Member

For those of you following along, the issue we have is this:

=== NAME  TestIntegration/Integration/PoetryDepOnly/when_building_an_app_with_poetry_dependency_management/creates_a_working_OCI_image_with_a_start_command
    poetry_dep_only_test.go:78: 
        Timed out after 10.001s.
        Expected
        	docker container id: ded9c549caefc04faec5bb908b76d7e1714c091ca32f5ac604d8ca31ad189a89
        to be available.
        
        Container logs:
        
        Traceback (most recent call last):
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/bin/gunicorn", line 5, in <module>
            from gunicorn.app.wsgiapp import run
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/lib/python3.12/site-packages/gunicorn/app/wsgiapp.py", line 9, in <module>
            from gunicorn.app.base import Application
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/lib/python3.12/site-packages/gunicorn/app/base.py", line 11, in <module>
            from gunicorn import util
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/lib/python3.12/site-packages/gunicorn/util.py", line 25, in <module>
            import pkg_resources
        ModuleNotFoundError: No module named 'pkg_resources'

We don't feel comfortable releasing the buildpacks until we understand why poetry seems to be failing - and ideally resolved the issue! If anyone has any thoughts please feel free to share, otherwise we'll work on this when we have time.

@TheSuperiorStanislav
Copy link

For those of you following along, the issue we have is this:

=== NAME  TestIntegration/Integration/PoetryDepOnly/when_building_an_app_with_poetry_dependency_management/creates_a_working_OCI_image_with_a_start_command
    poetry_dep_only_test.go:78: 
        Timed out after 10.001s.
        Expected
        	docker container id: ded9c549caefc04faec5bb908b76d7e1714c091ca32f5ac604d8ca31ad189a89
        to be available.
        
        Container logs:
        
        Traceback (most recent call last):
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/bin/gunicorn", line 5, in <module>
            from gunicorn.app.wsgiapp import run
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/lib/python3.12/site-packages/gunicorn/app/wsgiapp.py", line 9, in <module>
            from gunicorn.app.base import Application
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/lib/python3.12/site-packages/gunicorn/app/base.py", line 11, in <module>
            from gunicorn import util
          File "/layers/paketo-buildpacks_poetry-install/poetry-venv/default-app-xS3fZVNL-py3.12/lib/python3.12/site-packages/gunicorn/util.py", line 25, in <module>
            import pkg_resources
        ModuleNotFoundError: No module named 'pkg_resources'

We don't feel comfortable releasing the buildpacks until we understand why poetry seems to be failing - and ideally resolved the issue! If anyone has any thoughts please feel free to share, otherwise we'll work on this when we have time.

Hmm, I guess setuptools is either missing or broken
https://stackoverflow.com/questions/7446187/no-module-named-pkg-resources

@iloveitaly
Copy link

Bummer! I was hoping to play with CNB with my latest project, but this makes it unusable for me.

@TheSuperiorStanislav
Copy link

Any news/progress with this?

@thitch97
Copy link
Contributor

thitch97 commented Jan 25, 2024

Any news/progress with this?

We were able to get the poetry-install tests passing by explicitly including setuptools in the test applications since python 3.12 no longer includes setuptools by default. We will need to evaluate long-term solutions for supporting this new direction for Python, but for now that should get builds passing.

@thitch97 thitch97 closed this Jan 25, 2024
auto-merge was automatically disabled January 25, 2024 17:01

Pull request was closed

@thitch97 thitch97 reopened this Jan 25, 2024
@arjun024 arjun024 closed this Feb 13, 2024
@arjun024 arjun024 reopened this Feb 13, 2024
@arjun024 arjun024 force-pushed the automation/buildpack.toml/update branch from 7bb8558 to 4029c04 Compare February 13, 2024 21:01
@arjun024
Copy link
Member

Also includes commit that adds setuptools to test app's pyproject.toml:

https://python-poetry.org/blog/announcing-poetry-1.7.0/#official-support-for-python-312:

If you rely on setuptools or wheel, please make it an explicit dependency in your pyproject.toml.

@arjun024 arjun024 enabled auto-merge (rebase) February 13, 2024 21:04
@arjun024 arjun024 merged commit 890c590 into main Feb 13, 2024
8 checks passed
@arjun024 arjun024 deleted the automation/buildpack.toml/update branch February 13, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants