Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arguments when using BP_DIRECT_PROCESS #253

Merged

Conversation

c0d1ngm0nk3y
Copy link
Contributor

When using BP_DIRECT_PROCESS because you do not have a bash, the buildpack must tokenize the command string in case on arguments.

Summary

In this case, do the same as for the tiny stacks.

Use Cases

In case the process you wanna start has some arguments.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner November 8, 2024 14:11
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Nov 8, 2024
@dmikusa dmikusa merged commit c9bb5d3 into paketo-buildpacks:main Nov 8, 2024
7 checks passed
@dmikusa
Copy link
Contributor

dmikusa commented Nov 8, 2024

Good catch, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants