Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BP_DIRECT_PROCESS to enable run images without shell #247

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

c0d1ngm0nk3y
Copy link
Contributor

Fixes #246

Summary

This pr introduces BP_DIRECT_PROCESS to force the processes from the Procfile to be started without shell.

Use Cases

A run image without shell with another stack other stack than the hardcoded tiny ones. See #246 for details.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner September 11, 2024 11:55
@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Sep 18, 2024
@dmikusa
Copy link
Contributor

dmikusa commented Sep 18, 2024

This looks good, in addition to your technical description in the README, I would just like to position this feature as a way for users to prepare. Because we will be moving to having everything be a direct process (forced by CNB), I'd like to describe this new env variable in the README as a way for users to opt-in now and prepare for this change.

I'd also like the README to give notice now that a.) the next major release of procfile buildpack will make the change to requiring direct processes and b.) once we require everything to use direct processes this setting will be removed.

@loewenstein-sap
Copy link

Hey, @dmikusa, did you have a chance to look at this again. Feedback should be addressed.

@dmikusa
Copy link
Contributor

dmikusa commented Oct 4, 2024

Sorry for the delay. Yes, looks good. Thanks for adding that. If you can just update your branch, I'll get this merged.

@dmikusa dmikusa merged commit 589e37c into paketo-buildpacks:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using run image without bash
3 participants