Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #111: Adoptium actions adds source #1300

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Issue #111: Adoptium actions adds source #1300

merged 1 commit into from
Oct 6, 2023

Conversation

anthonydahanne
Copy link
Member

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner September 26, 2023 19:31
@anthonydahanne anthonydahanne added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Sep 26, 2023
@anthonydahanne
Copy link
Member Author

@pivotal-david-osullivan fixed!

@anthonydahanne anthonydahanne merged commit 32f0008 into main Oct 6, 2023
5 checks passed
@anthonydahanne anthonydahanne deleted the 111-adoptium-source branch October 6, 2023 12:10
@anthonydahanne
Copy link
Member Author

@pivotal-david-osullivan I have not waited for your second feedback; but I believe I stuck to your recommendations!

This was referenced Jan 18, 2024
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan left review comments

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonydahanne @dmikusa @pivotal-david-osullivan