-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add deprecation_date
field to buildpack dependencies if requested
#345
Automatically add deprecation_date
field to buildpack dependencies if requested
#345
Conversation
I don't feel like we should pull in a dependency on github.com/kobayashi/eol. It's a 0.1.0 release and hasn't been updated in over a year (last commit). It doesn't show strong signs of life. If I'm missing something there please let me know. It may be a little more work, but there are only three API calls for the API itself, https://endoflife.date/docs/api. Do you have any objections to just making HTTP calls directly to the API? You could add a client under the Aside from that, 👍 I like the idea. Automating metadata information is great. |
good point, I've moved the implementation to the internal package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller comments...
internal/eol_test.go
Outdated
]`))) | ||
}) | ||
|
||
it("returns correct cycle", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 3 test cases would be possible in the first context, right?
Co-authored-by: Pavel Busko <[email protected]> Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
5608cbd
to
47d06f6
Compare
79e02ff
to
f35f117
Compare
@dmikusa We call the API directly instead of using the additional dependency like you proposed in this comment. Maybe you can have another look. |
@dmikusa is there anything else blocking the PR from being merged? |
Signed-off-by: Daniel Mikusa <[email protected]>
Summary
Automatically populate
deprecation_date
for dependenciesUse Cases
This change adds the
--eol-id
flag to theupdate-buildpack-dependencies
cmd. When the flag is set, the product the EOL date is looked up for a product (the--eol-id
flag), formatted and added to thedeprecation_date
field.Checklist