Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github 107 #109

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix Github 107 #109

merged 1 commit into from
May 21, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented May 21, 2024

Summary

A different fix for 107. It swaps Python for the all module that way the buildplan doesn't need to change.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Fix Github 107
88c9067 
A different fix for 107. It swaps Python for the `all` module that way the buildplan doesn't need to change.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:bug A general bug labels May 21, 2024
@dmikusa dmikusa requested a review from a team as a code owner May 21, 2024 03:15
@dmikusa dmikusa merged commit e37e679 into main May 21, 2024
7 checks passed
@dmikusa dmikusa deleted the gh-107 branch May 21, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmikusa