Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Commit

Permalink
respond to PR review comments
Browse files Browse the repository at this point in the history
fix typo in GenerateFromDependency arg
  • Loading branch information
Frankie Gallina-Jones authored and ForestEckhardt committed Mar 1, 2022
1 parent a4cfe5a commit 2673f42
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func Build(
logger.GeneratingSBOM(depLayer.Path)
var sbomContent sbom.SBOM
duration, err = clock.Measure(func() error {
sbomContent, err = sbomGenerator.GenerateFromDependency(dependency, context.WorkingDir)
sbomContent, err = sbomGenerator.GenerateFromDependency(dependency, depLayer.Path)
return err
})
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion build_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func testBuild(t *testing.T, context spec.G, it spec.S) {
URI: "dep-dependency-uri",
Version: "dep-dependency-version",
}))
Expect(sbomGenerator.GenerateFromDependencyCall.Receives.Dir).To(Equal(workingDir))
Expect(sbomGenerator.GenerateFromDependencyCall.Receives.Dir).To(Equal(filepath.Join(layersDir, "dep")))

Expect(buffer.String()).To(ContainSubstring("Some Buildpack some-version"))
Expect(buffer.String()).To(ContainSubstring("Executing build process"))
Expand Down

0 comments on commit 2673f42

Please sign in to comment.