Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Completed #19

wants to merge 2 commits into from

Conversation

jonahroth
Copy link

@maxdignan
Copy link

This seems good.

maxdignan
maxdignan reviewed May 27, 2016
View reviewed changes
gem_city.rb
happiness_vals = []
happiness = 0
(1..@population).each do
happiness_vals.push(rand((100 - successful_crime_rate)..100))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move out the logic in this loop to another function, cause it's a little hairy in here with the rands and the constant values

@paradime
Copy link
Contributor

Looking good so far, you should try out the extra credit, Using TDD!

@jonahroth
Copy link
Author

My impression from the instructions was that I was supposed to get the code to pass the Rubocop tests, which it does. These are great notes and good to keep in mind for the future though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahroth @maxdignan @paradime