Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brendan's Rubocop solution #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions GemCity.rb

This file was deleted.

55 changes: 55 additions & 0 deletions gem_city.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# This class represents the town of GemCity
# This is a town riddled with crime but we can find out how happy the town is
class GemCity
attr_reader :population

def initialize
@people = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting these out to @thieves and @officers will probably simplify things.

thieves: 5,
officers: 1
}
@population = 50
end

def thieves(thieves_number = @people[:thieves])
@people[:thieves] = thieves_number
end

def officers
@people[:officers]
end

def num_officers(officers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setter methods can be named with a trailing =.

def officers=(new_officer_count)
  @officers = new_officer_count
end

makes this work:

GemCity.new.officers = 30

@people[:officers] = officers
end

def happiness_of_town
# happiness is random... people don't know what they want!
happiness_vals = []
happiness = 0
index = 0

until index >= @population
happiness_vals.push(rand((100 - successful_crime_rate)..100))
index += 1
end

happiness_vals.each { |value| happiness += value }

happiness / 100
end

def successful_crime_rate
thieves = @people[:thieves]
officers = @people[:officers]

if thieves <= 0 || officers > thieves
odds_percent = 0
else
odds = 1 - officers.to_f / thieves.to_f
odds_percent = odds * 100
end

odds_percent
end
end
6 changes: 3 additions & 3 deletions gem_city_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require 'rspec'
require_relative 'GemCity' # This line may need to be changed
require_relative 'gem_city' # This line may need to be changed

describe 'Gem City' do
let(:city) { GemCity.new }
Expand All @@ -16,7 +16,7 @@

it 'officers = thieves' do
city.thieves 1
city.setOfficers 1 # This line may need to be changed
city.num_officers 1 # This line may need to be changed
expect(city.successful_crime_rate).to eq(0)
end

Expand All @@ -27,7 +27,7 @@

it 'officers > thieves' do
city.thieves 1
city.setOfficers 2 # This line may need to be changed
city.num_officers 2 # This line may need to be changed
expect(city.successful_crime_rate).to eq(0)
end
end
Expand Down