All Tests Pass #126
Open
All Tests Pass #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in all code and made sure that the tests pass.
djlax805
reviewed
Jun 5, 2020
| end | ||
|
|
||
| def fetch_CD_animals(input) | ||
| #implement your solution here | ||
| input.grep(/^[cd]/i) |
There was a problem hiding this comment.
Making it hard on yourself! I like the creativity, before using a Regex, can you think of any other methods you might try?
There was a problem hiding this comment.
Potentially the use of input.select or input.find_all in order to locate the "c" or "d".
input.find_all {|animal| animal.start_with?('c', 'd')}
There was a problem hiding this comment.
Perfect - What you did was fine, just wanted to suggest that regex aren't always the best solution even if they are very powerful (hard to read and maintain).
SNMellott
commented
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in all code and made sure that the tests pass.