finished challenge #69

carakane · 2018-05-11T19:46:34Z

mikegee · 2018-05-14T15:07:56Z

lib/tree.rb

+      self.height += 1
+    end
+    self.age > 8 ? self.add_apples : false
+    self.dead? ? self.alive = false : self.alive = true


Flipping this around is a bit simpler, I think:

self.alive = !self.dead?

mikegee · 2018-05-14T15:09:51Z

lib/tree.rb

  end

  def add_apples
+    3.times do self.apples << Apple.new("red", rand(2..4)) end


Rubyists tend to use curly braces for single-line blocks:

3.times { self.apples << Apple.new("red", rand(2..4)) }

mikegee · 2018-05-14T15:11:24Z

Looks really good to me!

jaybobo · 2018-05-15T15:18:44Z

spec/tree_spec.rb

+    expect(fuji.alive).to be(true)
+  end
+
+  it 'stops growing after it is 20 feet tall' do


looks good but keep in mind using context to clean it defs like this and make them more readable.

finished challenge

fbe3e5c

mikegee reviewed May 14, 2018

View reviewed changes

jaybobo reviewed May 15, 2018

View reviewed changes

Provide feedback