Matt Crocco solution & tests #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybobo
reviewed
Jun 6, 2017
|
|
||
| def initialize | ||
| def initialize(max_possible_age=10, max_growth: 3, apple_color: 'orange') | ||
| raise ArgumentError, 'Ages must be positive and non-zero' if max_possible_age <= 0 |
There was a problem hiding this comment.
I like this. One thing you'll see are custom errors. Something like...
class Tree
class AgeError < StandardError; end
def initialize
`raise AgeError.new(msg)`
end
end| end | ||
|
|
||
| def age! | ||
| @age += 1 | ||
|
|
||
| if @age > @max_age |
There was a problem hiding this comment.
| end | ||
|
|
||
| it 'starts out alive' do | ||
| expect(tree).not_to be_dead |
| expect(tree).not_to be_dead | ||
| end | ||
|
|
||
| it 'starts out with no apples' do |
There was a problem hiding this comment.
I love the story approach of your tests. Keep in mind using contexts to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.