Pdt24 25 | Create a wrapper for environment variables #9
Conversation
pratham-outside
requested review from
noxiousghost,
arjandhakal and
Nijarshrestha
src/main.ts
Outdated
| await app.listen(process.env.APP_PORT ?? 3000, () => { | ||
| console.info('Listening to server....'); | ||
| console.info(`Server listening at port http://localhost:${process.env.APP_PORT}`); | ||
| const port = envVariables.APP_PORT ?? 3000; |
There was a problem hiding this comment.
No need for default value if we're already defining it in envVariables
src/app.module.ts
Outdated
| import { Module } from '@nestjs/common'; | ||
| import { AppController } from './app.controller'; | ||
| import { AppService } from './app.service'; | ||
| import { validate } from './config/env.config'; | ||
| import { ConfigModule } from '@nestjs/config'; |
There was a problem hiding this comment.
Please prefer import aliases "@/*" rather than relative imports.
It will help a lot for code organization.
src/config/env.config.ts
Outdated
| }) | ||
| .required(); | ||
|
|
||
| export const validate = (): object => { |
There was a problem hiding this comment.
Use return type z.infer<typeof validationSchema> instead of object
src/config/env.config.ts
Outdated
| @@ -0,0 +1,48 @@ | |||
| import { z } from 'zod'; | |||
| export const envVariables = { | |||
There was a problem hiding this comment.
| export const envVariables = { | |
| export const env = { |
src/scripts/orm.config.ts
Outdated
| username: process.env.POSTGRES_USER, | ||
| password: process.env.POSTGRES_PASSWORD, | ||
| database: process.env.POSTGRES_DB, | ||
| port: +(envVariables.POSTGRES_PORT ?? '5432'), |
There was a problem hiding this comment.
After we return z.infer<typeof validationSchema> env.POSTGRES_PORT will not be falsey.
src/scripts/orm.config.ts
Outdated
| database: envVariables.POSTGRES_DB, | ||
| synchronize: false, // Should be false in production to use migrations |
There was a problem hiding this comment.
| database: envVariables.POSTGRES_DB, | |
| synchronize: false, // Should be false in production to use migrations | |
| database: envVariables.POSTGRES_DB, | |
| synchronize: ${env.NODE_ENV === APP_ENVIRONVENT.PRODUCTION} |
There was a problem hiding this comment.
Typo:
env.NODE_ENV !== APP_ENVIRONVENT.PRODUCTION
src/scripts/orm.config.ts
Outdated
| username: env.POSTGRES_USER, | ||
| password: env.POSTGRES_PASSWORD, | ||
| database: env.POSTGRES_DB, | ||
| synchronize: env.NODE_ENV === APP_ENVIRONVENT.PRODUCTION ? false : true, // Should be false in production to use migrations |
There was a problem hiding this comment.
| synchronize: env.NODE_ENV === APP_ENVIRONVENT.PRODUCTION ? false : true, // Should be false in production to use migrations | |
| synchronize: env.NODE_ENV === APP_ENVIRONVENT.DEVELOPMENT, |
src/config/env.config.ts
Outdated
| DEFAULT = 587, | ||
| TLS = 465, | ||
| } | ||
| const validationSchema = z |
There was a problem hiding this comment.
validationSchema-> appEnvSchema
.gitignore
Outdated
| @@ -54,3 +54,5 @@ pids | |||
|
|
|||
| # Diagnostic reports (https://nodejs.org/api/report.html) | |||
| report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json | |||
|
|
|||
| ormconfig.json | |||
There was a problem hiding this comment.
should this file be ignored @pratham-outside
|
Tasks
Changes