PDT24-24 | Create logger wrapper #10

noxiousghost · 2024-12-24T06:37:13Z

Tasks

Create logger wrapper for the application

Changes

Setup winston and Nest-winston for creating a custom logger.
Overwritten the default nestjs logger with new winston logger.

Notes

Now the logging behavior of the application depends upon the APP_ENV environment variable. In production, the logs are saved in /logs/all.log and /logs/error.log files and in development, the logs are simply printed in console.

pratham-outside · 2024-12-30T09:57:46Z

docker-compose.yml

@@ -6,7 +6,7 @@ services:
      POSTGRES_PASSWORD: ${POSTGRES_PASSWORD}
      POSTGRES_DB: ${POSTGRES_DB}
    ports:
-      - 5432:5432
+      - 5433:5432


5432:5432 chai kina hatako ? eutai rakhda ni hunxa hola

I already have postgres installed in my main machine and I assume most of the people already have it too so keeping 5432 is causing port conflict.

pratham-outside · 2024-12-30T10:00:38Z

src/config/logger.config.ts

+				new transports.File({ filename: 'logs/errors.log', level: 'error' }),
+				new transports.File({ filename: 'logs/all.log' }),
+			]
+		: [new transports.Console({ format: format.combine(format.colorize({ all: true })) })],


Wont there be logger file for development ?

we can check all the logs in our console in development.

pratham-outside · 2024-12-30T10:02:19Z

src/config/logger.config.ts

@@ -0,0 +1,16 @@
+import { format, transports } from 'winston';
+const isProduction = process.env.APP_ENV === 'production';


After merging PDT24-25 lets use env.NODE_ENV ===APP_ENVIRONVENT.PRODUCTION

pratham-outside · 2024-12-30T10:05:03Z

src/scripts/orm.config.ts

@@ -9,7 +9,7 @@ const dataBaseConfigurations = {
 	password: process.env.POSTGRES_PASSWORD,
 	database: process.env.POSTGRES_DB,
 	synchronize: false, // Should be false in production to use migrations
-	logging: true,
+	logging: process.env.APP_ENV === 'production' ? false : true,


env.NODE_ENV === APP_ENVIRONVENT.PRODUCTION ? false: true

src/scripts/orm.config.ts

* feat: configure nodemailer servie for sending email * feat: create a basic email template for sending signup otp code * chore: rename param names and add function documentation * fix: use secure mailing port * refactor: remove sendEmail call from main and improve sendEmail method

sonarqubecloud · 2024-12-31T06:29:42Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

noxiousghost requested review from Nijarshrestha, arjandhakal, rrojan and pratham-outside December 24, 2024 06:37

noxiousghost force-pushed the PDT24-24 branch from 8afcff1 to 2bc3c30 Compare December 26, 2024 09:23

noxiousghost added 2 commits December 26, 2024 18:04

feat: add logging service with winston

fcc07df

chore(logging): use and fix logging information

809a8d5

noxiousghost force-pushed the PDT24-24 branch from 2bc3c30 to 809a8d5 Compare December 30, 2024 09:54

pratham-outside reviewed Dec 30, 2024

View reviewed changes

noxiousghost changed the base branch from main to PDT24-45 December 30, 2024 10:22

noxiousghost self-assigned this Dec 30, 2024

arjandhakal approved these changes Dec 31, 2024

View reviewed changes

noxiousghost requested a review from saugatmaharjan December 31, 2024 04:50

saugatmaharjan reviewed Dec 31, 2024

View reviewed changes

src/scripts/orm.config.ts Outdated Show resolved Hide resolved

Nijarshrestha approved these changes Dec 31, 2024

View reviewed changes

noxiousghost and others added 2 commits December 31, 2024 11:31

refactor: remove ternary operator

563390e

noxiousghost merged commit 0947ed2 into PDT24-45 Dec 31, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PDT24-24 | Create logger wrapper #10

PDT24-24 | Create logger wrapper #10

noxiousghost commented Dec 24, 2024

pratham-outside Dec 30, 2024

noxiousghost Dec 30, 2024 •

edited

Loading

pratham-outside Dec 30, 2024

noxiousghost Dec 30, 2024

pratham-outside Dec 30, 2024 •

edited

Loading

pratham-outside Dec 30, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 31, 2024

		@@ -0,0 +1,16 @@
		import { format, transports } from 'winston';
		const isProduction = process.env.APP_ENV === 'production';

PDT24-24 | Create logger wrapper #10

PDT24-24 | Create logger wrapper #10

Conversation

noxiousghost commented Dec 24, 2024

Tasks

Changes

Notes

pratham-outside Dec 30, 2024

Choose a reason for hiding this comment

noxiousghost Dec 30, 2024 • edited Loading

Choose a reason for hiding this comment

pratham-outside Dec 30, 2024

Choose a reason for hiding this comment

noxiousghost Dec 30, 2024

Choose a reason for hiding this comment

pratham-outside Dec 30, 2024 • edited Loading

Choose a reason for hiding this comment

pratham-outside Dec 30, 2024 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 31, 2024

Quality Gate passed

noxiousghost Dec 30, 2024 •

edited

Loading

pratham-outside Dec 30, 2024 •

edited

Loading

pratham-outside Dec 30, 2024 •

edited

Loading