Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.0 #4962

Closed
wants to merge 54 commits into from
Closed

Release 1.3.0 #4962

wants to merge 54 commits into from

Conversation

Tempo-anon
Copy link
Collaborator

@Tempo-anon Tempo-anon commented Dec 2, 2024

2024/12/03 The Balanced Friendship :) Update

Major Changes

  • Soothe Bells are now Great Tier
  • Map's weight increased to 2 as a result of the above
  • Friendship gained increased, see <#1241969938789437450> for details
  • New additions to the Legendary Gacha, see <#1241969938789437450> for details
  • Credits on GitHub have been updated with the names of contributors from the last few months! Check them out!!

Minor Changes

  • Toxic/Flame Orb spawn chances changed so that they will no longer spawn for Pokémon that cannot be statused by it because of their ability or type, nor for unimplemented moves (Fling, Switcheroo, and Trick)
  • 'Breeders in Space' achievement can now be unlocked through battling regular Breeders in Space as well
  • The Forest biome has a new custom track by Andr06, titled 'Rogue's Echoes'
  • The egg skip prompt now shows the number of eggs hatching
  • An (+) indicator is shown if you catch a non-shiny Pokémon after having only caught shiny versions of it before
  • Eviolite will no longer appear in rolls when all unevolved Pokémon in the party already have one
  • Mobile devices can now disable the touchpad. But the game will ask for confirmation before disabling touchpad controls just in case
  • An option to download a copy of the local save data has been added to the login screen

Implementations and fixes

Moves

  • Powder
  • Instruct ☝️
  • Roar / Dragon Tail / Whirlwind / Circle Throw will now retrieve a random party member if applicable
  • Octolock properly interacts with the Ghost type

Abilities

  • Honey Gather and Pickup will only activate if the battle was won
  • Serene Grace no longer doubles King's Rock chances
  • Supersweet Syrup now activates whenever the source enters the field, not just on the first turn
  • Various Wimp Out/Emergency Exit bugs have been fixed
  • Stakeout should trigger if the opponent switches with a switch out move
  • Analytic will only increase damage if the user moves last
  • Arena Trap no longer lingers upon switch out

QOL

  • More localization
  • Fixed clipping sprites for Skorupi and Parasect

Other bug fixes

  • Shiny-related bugs in Mystery Encounters have been addressed
  • ME-related defeats are now viewable in Run History / Save Preview
  • Post Summon abilities will activate upon selecting and canceling a first-turn switch out

Do not squash and merge!

DayKev and others added 30 commits November 18, 2024 14:32
Reduces the size of files significantly by changing the .png encoding format.
* Rename `DamagePhase` to `DamageAnimPhase`

* Fix unreliable Speed Boost test
)

* Analytic only increases damage if the user moves last

* Return `isNullOrUndefined()` instead of `if` chain

---------

Co-authored-by: innerthunder <[email protected]>
…eeders (#4911)

* 'Breeders in Space' cheevo unlocks for normal and expert breeders

* Reduce breeder in space achievement points
…agon Tail) (#4881)

* Force switch implemenation

* Fix conditionals checking `SwitchType`

Use `prependToPhase()` instead of `unshiftPhase()`

* Update comments slightly, replace `||` chain with `.includes()`

---------

Co-authored-by: NightKev <[email protected]>
* fix first turn move + wimpoout

* Add comment about edge case issue

---------

Co-authored-by: NightKev <[email protected]>
* [sprite] add fixed Parasect front sprite by Kieran

* [sprite] add fixed Skorupi front sprite by Kieran

* [sprite] fix shiny skorupi fusions
#4903)

* Honey Gather and Pickup will only activate if the battle was won

* Add tests for Honey Gather

* Moves `highestEndlessWave` and `battles` stats outside of victory condition
It sounds less jarring now, loops a couple seconds earlier.
…ettings (#4949)

* [UI] Ask Confirmation before disabling touch controls

* show a message when asking for confirmation in settings

* small cleanup

* change settings message box to display 2 lines with word wrap
Will only show the (+) icon if you catch a non-shiny, have caught a shiny of that species before, and have not caught a non-shiny before.

Removed magic numbers from new non-shiny check

Co-authored-by: Riley Young <[email protected]>
Co-authored-by: NightKev <[email protected]>
* [Bug] Fix Eviolite Weight Condition

* Break Up Conditions for Legibility

---------

Co-authored-by: NightKev <[email protected]>
Fontbane and others added 11 commits December 1, 2024 17:38
…4921)

* Fix fusions learning moves of wrong component mon on evolution

* Apply suggestions from code review

Co-authored-by: Moka <[email protected]>

---------

Co-authored-by: NightKev <[email protected]>
Co-authored-by: Moka <[email protected]>
* [qol] add missing error messages in starter UI

* remove locale change

* revert empty party message change

---------

Co-authored-by: NightKev <[email protected]>
* catch Sprite.play() errors in egg hatch phase

* catch more Sprite.play() errors causing crashes if sprite missing

* Add changes suggested by PigeonBar

---------

Co-authored-by: NightKev <[email protected]>
Co-authored-by: Moka <[email protected]>
* new function

* weak attempt of documentation

* mysterious chest handled...? maybe.

* override comments

* one more instruction

* fixing up the logging lol

* lah

* fixing it up

* coommrent

* lalal

* run info fixes

* Addressed PigeonBar's comments

* Centered run info text + fixed trainer sprites.

* Fixed function name.

* Update tsdoc in `overrides.ts`

Co-authored-by: Moka <[email protected]>

* Fix tsdoc comment

* sligthly rewrite centering of biome and wave text in run info

---------

Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <[email protected]>
Co-authored-by: Moka <[email protected]>
Co-authored-by: Moka <[email protected]>
Co-authored-by: frutescens <info@laptop>
* [Balance] Adjust Flame/Toxic Orb Weight Functions

* Adjust Booleans

* Add Documentation

* Implement More Granularity

* Minor `if` Change
Co-authored-by: NightKev <[email protected]>
Co-authored-by: innerthunder <[email protected]>
Co-authored-by: Jannik Tappert <[email protected]>
* Powder basic implementation

* Add Powder integration tests

* Fix thaw test

* Use new test utils and type check function

* More edge case tests

* Make Powder (P)

* Add locale keys

* Add placeholder common anim

* Use CommonAnimPhase instead of async animation

* Add comments with new English text

* Make Powder `edgeCase` instead

* ESLint

* Fix imports

* Add `moveName` key arg for other languages

* ESLint

* Update locales

* Fix pages issues

* Update Powder explosion animation

* Update common-powder.json

* Update src/test/moves/powder.test.ts

Co-authored-by: NightKev <[email protected]>

* Remove lingering TIMEOUTs

* More test cleanup

---------

Co-authored-by: NightKev <[email protected]>
* [P1 Bug] Fix multi lens granting infinite Future Sight hits

* Updated `.partial()` tags

* Added corresponding TODO comments to tests
* Update passives.ts

* Update egg-moves.ts

* Update egg-moves.ts

* Update species-egg-tiers.ts

* Update egg-moves.ts

* Update egg-moves.ts

* Update starters cost

* Update egg-moves.ts

* fixed mispell

* update egg tests to match latest species egg tier changes

* Update starters.ts - fixed placements and reduced Duraludon back to 5

* Update species-egg-tiers.ts fixed placements

* Kartana and Iron Valiant passive change

* Update passives.ts

* Update egg-moves.ts

* Update species-egg-tiers.ts

* Update starters.ts

* fix '

---------

Co-authored-by: Moka <[email protected]>
Co-authored-by: Moka <[email protected]>
@Tempo-anon Tempo-anon added the Lead Dev Review Lead Dev Review is required label Dec 2, 2024
@Tempo-anon Tempo-anon requested review from a team as code owners December 2, 2024 20:44
* [Move][Beta] Powder edge cases

* Fix Heavy Rain check to account for weather suppression

Co-authored-by: NightKev <[email protected]>

* "{Pokemon} used {Fire-type move}!" now displays before Powder activation

Co-authored-by: innerthunder <[email protected]>

* Make `showMoveText()` and `showFailedText()` public for now

---------

Co-authored-by: NightKev <[email protected]>
Co-authored-by: innerthunder <[email protected]>
DayKev
DayKev previously approved these changes Dec 3, 2024
MokaStitcher
MokaStitcher previously approved these changes Dec 3, 2024
* Update egg-moves.ts

* Update egg-moves.ts
@MokaStitcher MokaStitcher dismissed stale reviews from DayKev and themself via 50a4669 December 3, 2024 20:22
* Create `CREDITS.md`

* Add categories

* added Firel biome

* Update README.md

Co-authored-by: Moka <[email protected]>

* Add Leparagon to Trainer Sprites

* Add balance team

* Update music credits for Andr06 (new Forest BGM)

* Add dev team and past contributors to credits

* Add link to wiki credits page for pokemon sprites

* Update indentation

* Update dev credits

* Add pancakes

* Add wormhood

* Add Mystery Event Sprites section in Art

Add Past Contributors section in Balance

* Standardize emojis to primary categories only

* Update Mystery Event Sprites section

* Fix typo

* Add wiki team

* Add Special Thanks section

Used for external contributors/community members that aren't part of
the main PokeRogue team

* Add Discord mod team

* Add Translation team

* Add External Tools section

* Update CREDITS.md

* Update CREDITS.md

* add missing é in Poké in various spot

* Add Red (iOS App) to External Tools section

* Update Red's credit

* Update art credits

* Update vari and kieran

---------

Co-authored-by: damocleas <[email protected]>
Co-authored-by: Moka <[email protected]>
Co-authored-by: Lugiad <[email protected]>
Co-authored-by: Moka <[email protected]>
@DayKev DayKev closed this Dec 3, 2024
@Tempo-anon
Copy link
Collaborator Author

Denying me a giant number of lines contributed to the repo :despair:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead Dev Review Lead Dev Review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.