[Bug] Analytic should only increase damage if the user moves last #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DayKev
added
Move
58 tasks
DayKev
changed the title
Co-authored-by: innerthunder <[email protected]>
frutescens
approved these changes
Nov 28, 2024
innerthunder
approved these changes
Nov 28, 2024
torranx
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
In doubles, Analytic will no longer erroneously boost damage if the target moves before the user and the other Pokémon have not.
Why am I making these changes?
Move is bugged, see #3503 (comment)
What are the changes from a developer perspective?
The condition function for Analytic is changed.
Tests were added for Analytic.
How to test the changes?
npm run test analyticChecklist
betaas my base branch[ ] Have I tested the changes manually?npm run test)npm run create-test) or updated existing tests related to the PR's changes?[ ] Have I provided screenshots/videos of the changes (if applicable)?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?