[Move] Remove .edgeCase() from fully implemented moves
#4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
innerthunder
previously approved these changes
Nov 15, 2024
This includes Sunsteel Strike, Moongeist Beam and Photon Geyser
DayKev
force-pushed
the
remove-edgecase
branch
from
4c15c38
to
5a7aeb3
Compare
|
Added comment in tests to mention the other 2 moves. |
innerthunder
approved these changes
Nov 15, 2024
torranx
approved these changes
Nov 15, 2024
frutescens
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
The moves are complete. cf #3503 (comment)
What are the changes from a developer perspective?
.edgeCase()is removed from some Sunsteel Strike, Moongeist Beam and Photon Geyser.Screenshots/Videos
npm run test moongeist_beamChecklist
betaas my base branch[ ] Have I considered writing automated tests for the issue?[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?[ ] Have I tested the changes (manually)?npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?