Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other(qol)]: Lint pr title #1960

Closed
wants to merge 8 commits into from

Conversation

OrangeRed
Copy link
Collaborator

@OrangeRed OrangeRed commented Jun 8, 2024

What are the changes?

Add workflow to lint the title of PR so it matches the conventionalcommits spec

Custom Conventional Commits spec

[bug(ui)]: Fix female trainer names
 ^   ^     ^
 |   |     |__ Subject
 |   |________ Scope
 |____________ Prefix

Why am I doing these changes?

This is the first step to needed to auto generate changelogs from commit history

What did change?

new workflow

Screenshots/Videos

N/A

How to test the changes?

make a new branch, make some dummy commits and open a pull request onto OrangeRed/lint-pr-title trigger the workflow.
You can test the regex that I'm using here: https://regex101.com/r/42XxHM/1

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    - [ ] Are all unit tests still passing? (npm run test)
    - [ ] Are the changes visual?
    - [ ] Have I provided screenshots/videos of the changes?

@OrangeRed OrangeRed changed the title Lint pr title other(qol): Lint pr title Jun 8, 2024
@Madmadness65 Madmadness65 added the Enhancement New feature or request label Jun 8, 2024
@OrangeRed OrangeRed changed the title other(qol): Lint pr title [Other(qol)]: Lint pr title Jun 10, 2024
@flx-sta flx-sta requested a review from a team as a code owner October 2, 2024 03:05
@flx-sta
Copy link
Collaborator

flx-sta commented Oct 2, 2024

Closed for now.
We might come back to it at another time

@flx-sta flx-sta closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants