Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set UID when setting Pagure PR flag #2666

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Set UID when setting Pagure PR flag #2666

merged 1 commit into from
Nov 29, 2024

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Nov 29, 2024 •
edited
Loading

Generate it from the check_name. This prevents creating multiple separate flags (for each state). This was already introduced in 0d4bc36 .

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

@lbarcziova lbarcziova requested a review from a team as a code owner November 29, 2024 12:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/8de4ed1d7ed94951829b3b4ba1b92a03

✔️ pre-commit SUCCESS in 2m 09s
✔️ packit-service-tests SUCCESS in 2m 33s

@lbarcziova lbarcziova self-assigned this Nov 29, 2024
@nforro
Copy link
Member

nforro commented Nov 29, 2024

This prevents not creating multiple separate flags (for each state).

Should not be in this sentence? To me it seems to contradict the code change.

@lbarcziova
Set UID when setting Pagure PR flag
3e348a5 
Generate it from the check_name. This prevents creating
multiple separate flags (for each state). This was already introduced
in 0d4bc36 .
@lbarcziova
Copy link
Member Author

Should not be in this sentence? To me it seems to contradict the code change.

Fixed.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/126c2648fbfd475b9ddc99565541ba09

✔️ pre-commit SUCCESS in 2m 27s
✔️ packit-service-tests SUCCESS in 2m 52s

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Nov 29, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/96b1babcacdd43a99f1e7500697c1a4b

✔️ pre-commit SUCCESS in 2m 07s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e50032d into packit:main Nov 29, 2024
5 checks passed
@lbarcziova lbarcziova deleted the pagure-reporting-flag-uid branch November 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nforro nforro nforro approved these changes

Assignees

@lbarcziova lbarcziova

Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Packit Kanban Board
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbarcziova @nforro