Choose only jobs with sidetag group for koji-tag command #2636
Conversation
|
Build failed. ✔️ pre-commit SUCCESS in 2m 17s |
| if any(j for j in matching_jobs if compare_jobs_without_triggers(job, j)): | ||
| continue | ||
| # in case of koji-tag command, match only koji_build jobs with sidetag group | ||
| if event_is_koji_tag_command() and not job.sidetag_group: |
There was a problem hiding this comment.
Probably a silly question for a far edge use case: any sidetag_group is ok? Can be there more side_tag groups for a package? Does it make any sense to have a more specific filter?
There was a problem hiding this comment.
There could be more different groups, but the filtering would have to be done in the handler (and the group name would be parsed from the comment command there). It's not currently implemented, so the latest build of such package would be tagged into all groups, but I don't think anybody will be doing that, we can implement it later if needed.
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 15s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 13s |
softwarefactory-project-zuul
bot
merged commit 6ccf229
into
packit:main
The check is also in the handler, but doing it here prevents multiple
The task was acceptedmessages.