Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not explicitly call session.begin() #2629

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Do not explicitly call session.begin() #2629

merged 1 commit into from
Nov 12, 2024

Conversation

majamassarini
Copy link
Member

@majamassarini majamassarini commented Nov 12, 2024 •
edited
Loading

@majamassarini majamassarini requested a review from a team as a code owner November 12, 2024 10:34
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a9a4b981ee344073983f02648c0fa731

✔️ pre-commit SUCCESS in 2m 15s
✔️ packit-service-tests SUCCESS in 2m 44s

@majamassarini majamassarini force-pushed the fix/packit-service/2604-3rd branch from 7edd18b to b3b38cb Compare November 12, 2024 11:07
@majamassarini majamassarini changed the title Handle InvalidRequestError Do not explicitly call session.begin() Nov 12, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/677c1a27223c4a85aa0d78cc6a4126dd

✔️ pre-commit SUCCESS in 2m 07s
✔️ packit-service-tests SUCCESS in 2m 37s

@majamassarini majamassarini force-pushed the fix/packit-service/2604-3rd branch from 7f28d32 to 0deb846 Compare November 12, 2024 11:12
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c827427d50b34d20a4c70faa8b37692c

✔️ pre-commit SUCCESS in 2m 05s
✔️ packit-service-tests SUCCESS in 2m 41s

@majamassarini majamassarini force-pushed the fix/packit-service/2604-3rd branch from 0deb846 to 66f4be9 Compare November 12, 2024 11:19
@majamassarini
Do not explicitly begin() a transaction.
5d6bc63 
The previous code was raising an InvalidRequestError.
@majamassarini majamassarini force-pushed the fix/packit-service/2604-3rd branch from 29ad792 to 5d6bc63 Compare November 12, 2024 11:21
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5e88ef1d05ca42d6b187935e4a239908

✔️ pre-commit SUCCESS in 2m 27s
✔️ packit-service-tests SUCCESS in 3m 05s

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Nov 12, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/de15da972eed49d1aefdf53c2a98fabb

✔️ pre-commit SUCCESS in 2m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 40bb0fc into packit:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@nforro nforro nforro approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majamassarini @nforro @lbarcziova