Skip to content

Commit

Permalink
Remove sync_default_files from method signatures
Browse files Browse the repository at this point in the history
synced_files has been removed.
files_to_sync is always initialized with the default files path.
If default files have not to be synchronized then they have to be removed from files_to_sync list.
  • Loading branch information
majamassarini committed Sep 20, 2024
1 parent 738ed55 commit 6c76c3e
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion packit_service/worker/handlers/distgit.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ def sync_branch(
create_pr=True,
local_pr_branch_suffix=branch_suffix,
use_downstream_specfile=is_pull_from_upstream_job,
sync_default_files=not is_pull_from_upstream_job,
add_pr_instructions=True,
resolved_bugs=self.get_resolved_bugs(),
release_monitoring_project_id=self.data.event_dict.get(
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/test_new_hotness_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ def test_new_hotness_update(new_hotness_update, sync_release_model):
create_pr=True,
local_pr_branch_suffix="update-pull_from_upstream",
use_downstream_specfile=True,
sync_default_files=False,
add_pr_instructions=True,
resolved_bugs=["rhbz#2106196"],
release_monitoring_project_id=4181,
Expand Down Expand Up @@ -388,7 +387,6 @@ def test_new_hotness_update_non_git(new_hotness_update, sync_release_model_non_g
create_pr=True,
local_pr_branch_suffix="update-pull_from_upstream",
use_downstream_specfile=True,
sync_default_files=False,
add_pr_instructions=True,
resolved_bugs=["rhbz#2106196"],
release_monitoring_project_id=4181,
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/test_pr_comment.py
Original file line number Diff line number Diff line change
Expand Up @@ -2698,7 +2698,6 @@ def _get_project(url, *_, **__):
create_pr=True,
local_pr_branch_suffix="update-pull_from_upstream",
use_downstream_specfile=True,
sync_default_files=False,
add_pr_instructions=True,
resolved_bugs=["rhbz#123", "rhbz#124"],
release_monitoring_project_id=None,
Expand Down Expand Up @@ -2866,7 +2865,6 @@ def _get_project(url, *_, **__):
create_pr=True,
local_pr_branch_suffix="update-pull_from_upstream",
use_downstream_specfile=True,
sync_default_files=False,
add_pr_instructions=True,
resolved_bugs=["rhbz#123", "rhbz#124"],
release_monitoring_project_id=None,
Expand Down
6 changes: 0 additions & 6 deletions tests/integration/test_release_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ def test_dist_git_push_release_handle(
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand Down Expand Up @@ -357,7 +356,6 @@ def test_dist_git_push_release_handle_multiple_branches(
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand Down Expand Up @@ -508,7 +506,6 @@ def test_dist_git_push_release_handle_one_failed(
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand All @@ -532,7 +529,6 @@ def test_dist_git_push_release_handle_one_failed(
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand Down Expand Up @@ -777,7 +773,6 @@ def test_retry_propose_downstream_task(
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand Down Expand Up @@ -891,7 +886,6 @@ def test_dont_retry_propose_downstream_task(
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand Down
1 change: 0 additions & 1 deletion tests/unit/test_steve.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ def test_process_message(event, private, enabled_private_namespaces, success):
create_pr=True,
local_pr_branch_suffix="update-propose_downstream",
use_downstream_specfile=False,
sync_default_files=True,
add_pr_instructions=True,
resolved_bugs=[],
release_monitoring_project_id=None,
Expand Down

0 comments on commit 6c76c3e

Please sign in to comment.