chore: install yarn deps in production mode #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://packit-dashboard-pr-329.surge.sh (deployed at Mon 11 Sep 2023, 17:54 UTC) |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 19s |
Venefilyn
requested changes
Sep 11, 2023
From the yarn docs: > Yarn will not install any package listed in `devDependencies` if the > `NODE_ENV` environment variable is set to `production`. Use this flag > to instruct Yarn to ignore `NODE_ENV` and take its production-or-not > status from this flag instead. This should ensure that no development dependencies, such as `surge`, are installed at all in the image that we use for deployments. Yet another follow-up to the vulnerability report for the MP+ deployment. Co-authored-by: Eric Gustavsson <[email protected]> Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
yarn-production-build
branch
from
e47ae58
to
c0f61ee
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 19s |
jpopelka
approved these changes
Sep 11, 2023
lbarcziova
approved these changes
Sep 12, 2023
|
@.SpyTec Sorry for the additional review request, but with the requested changes you blocked merging 😄 |
There is a way to dismiss review requests just above the merge button :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the yarn docs:
This should ensure that no development dependencies, such as
surge, are installed at all in the image that we use for deployments.Yet another follow-up to the vulnerability report for the MP+ deployment.